This is the remaining bit of s390 host support code from your earlier patch. Could you check if this bit is still needed?
Also, if it does something useful, I suspect that it is incomplete. gen_setcc duplicates the same logic, wouldn't it need to stay in sync? Thiemo --- qemu/target-i386/translate.c 2007-06-26 08:35:18.000000000 +0000 +++ qemu-s390/target-i386/translate.c 2007-07-30 13:57:39.000000000 +0000 @@ -1795,7 +1795,11 @@ case CC_OP_SUBW: case CC_OP_SUBL: case CC_OP_SUBQ: +#ifdef __s390__ + func = NULL; /* does not work on S/390 for unknown reasons */ +#else func = gen_jcc_sub[s->cc_op - CC_OP_SUBB][jcc_op]; +#endif break; /* some jumps are easy to compute */ @@ -1843,7 +1847,11 @@ func = gen_jcc_sub[(s->cc_op - CC_OP_ADDB) % 4][jcc_op]; break; case JCC_S: +#ifdef __s390__ + func = NULL; +#else func = gen_jcc_sub[(s->cc_op - CC_OP_ADDB) % 4][jcc_op]; +#endif break; default: func = NULL;