On 10 October 2012 11:00, Laurent Desnogues <laurent.desnog...@gmail.com> wrote:
> On Tue, Oct 9, 2012 at 11:13 PM, Peter Maydell <peter.mayd...@linaro.org>
> wrote:
>> On 9 October 2012 21:30, Aurelien Jarno <aurel...@aurel32.net> wrote:
>>> + if (im >= 0) {
>>> + tcg_out32(s, (cond << 28) | 0x05b00000 |
>>> + (rn << 16) | (rd << 12) | (im & 0xfff));
>>> + } else {
>>> + tcg_out32(s, (cond << 28) | 0x05300000 |
>>> + (rn << 16) | (rd << 12) | ((-im) & 0xfff));
>>> + }
>>
>> you could avoid the if() by just setting the U bit using "(im >= 0) << 23"
>> Clearer? Dunno.
>
> You also have to negate the im value so it's not enough to just
> change the opcode.
Doh, of course. Forget what I wrote, then :-)
-- PMM
