On Sat, Sep 01, 2012 at 12:43:41PM +0200, Stefan Weil wrote: > Report from smatch: > lm4549.c:234 lm4549_write_samples(14) error: > buffer overflow 's->buffer' 1024 <= 1024 > > There must be enough space to add two entries starting with index > s->buffer_level, therefore the old check was wrong. > > Signed-off-by: Stefan Weil <[email protected]> > --- > hw/lm4549.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches I've added Peter's comment to the commit message that the overflow condition doesn't actually happen since we advance by two at a time. Stefan
