On 09/19/2012 08:31 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > qapi-schema.json | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file modificato, 53 inserzioni(+) >
> ##
> +# @IPSocketAddress
> +#
> +# Captures the destination address of an IP socket
Given the presence of @to, would this read better as:
IP socket or socket range
> +#
> +# @host: host part of the address
> +#
> +# @port: port part of the address, or lowest port if @to is present
> +#
> +# @to: highest port to try
> +#
> +# @ipv4: whether to accept IPv4 addresses, default try both IPv4 and IPv6
> +# #optional
Isn't the #optional supposed to occur first after the colon, as in:
@ipv4: #optional whether to accept IPv4...
> +#
> +# @ipv6: whether to accept IPv6 addresses, default try both IPv4 and IPv6
> +# #optional
> +#
> +# Since 1.3
> +##
> +{ 'type': 'IPSocketAddress',
> + 'data': {
> + 'host': 'str',
> + 'port': 'str',
> + '*to': 'uint16',
Why is 'port' a string, but 'to' a uint16? Shouldn't they both be uint16?
--
Eric Blake ebl...@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
