On 09/14/2012 07:41 AM, Jeff Cody wrote: > Signed-off-by: Jeff Cody <jc...@redhat.com> > --- > qerror.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qerror.h b/qerror.h > index d0a76a4..7396184 100644 > --- a/qerror.h > +++ b/qerror.h > @@ -219,6 +219,9 @@ void assert_no_error(Error *err); > #define QERR_TOO_MANY_FILES \ > ERROR_CLASS_GENERIC_ERROR, "Too many open files" > > +#define QERR_TOP_NOT_FOUND \ > + ERROR_CLASS_GENERIC_ERROR, "Top image file %s not found" > +
Is this patch really still needed, now that the generic error handling is in? Shouldn't you instead be using error_setg() in patch 6/8 for the one place that prints this error message? -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
