On Fri, Sep 14, 2012 at 03:26:30PM +0300, Michael S. Tsirkin wrote: > I think it's best to smash the following patch into this one > otherwise review becomes painful. Some short notes: >
ok. > > --- > > hw/acpi_ich9.c | 315 ++++++++++++++++++ > > hw/acpi_ich9.h | 53 +++ > > hw/i386/Makefile.objs | 1 + > > hw/pc_q35.c | 378 +++++++++++++++++++++ > > hw/pci_ids.h | 14 + > > hw/q35.c | 877 > > +++++++++++++++++++++++++++++++++++++++++++++++++ > > hw/q35.h | 272 +++++++++++++++ > > hw/q35_smbus.c | 154 +++++++++ > > 8 files changed, 2064 insertions(+), 0 deletions(-) > > create mode 100644 hw/acpi_ich9.c > > create mode 100644 hw/acpi_ich9.h > > create mode 100644 hw/pc_q35.c > > create mode 100644 hw/q35.c > > create mode 100644 hw/q35.h > > create mode 100644 hw/q35_smbus.c > > > > diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c > > new file mode 100644 > > index 0000000..59c0807 > > --- /dev/null > > +++ b/hw/acpi_ich9.c > > @@ -0,0 +1,315 @@ > > +/* > > + * ACPI implementation > > + * > > + * Copyright (c) 2006 Fabrice Bellard > > + * > > + * This library is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU Lesser General Public > > + * License version 2 as published by the Free Software Foundation. > > + * > > + * This library is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with this library; if not, see > > <http://www.gnu.org/licenses/> > > + */ > > +/* > > + * Copyright (c) 2009 Isaku Yamahata <yamahata at valinux co jp> > > + * VA Linux Systems Japan K.K. > > + * > > Probably two headers should be combined. > > > + * This is based on acpi.c. > > This should probably go into commit log instead. > > > + */ > ok. > > .. > > > diff --git a/hw/acpi_ich9.h b/hw/acpi_ich9.h > > new file mode 100644 > > index 0000000..f55c0e9 > > --- /dev/null > > +++ b/hw/acpi_ich9.h > > @@ -0,0 +1,53 @@ > > +/* > > + * QEMU GMCH/ICH9 LPC PM Emulation > > + * > > + * Copyright (c) 2009 Isaku Yamahata <yamahata at valinux co jp> > > + * VA Linux Systems Japan K.K. > > + * > > + * This library is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU Lesser General Public > > + * License as published by the Free Software Foundation; either > > + * version 2 of the License, or (at your option) any later version. > > + * > > + * This library is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with this library; if not, see > > <http://www.gnu.org/licenses/> > > + */ > > + > > +#ifndef HW_ACPI_ICH9_H > > +#define HW_ACPI_ICH9_H > > + > > +#include "acpi.h" > > + > > +typedef struct ICH9_LPCPmRegs { > > This naming scheme conflicts with qemu coding style. > Pls use Ich9LpcPmRegs or something. > Same comment applies everywhere. > Ok, I'll also have to fix up some of the data structure naming in q35.h. Thanks, -Jason
