Hi, >>> It seems a bit odd that this is done in the ISA serial model >>> itself and not by the next level up wiring up some output >>> of the ISA serial device to some appropriate input... >> >> Suggestions how to do that are welcome. Preferably some which don't >> break on 'qemu -nodefault -device isa-serial,chardev=foo'. > > Add a qdev property?
And offload it to the user / management tool to get that correct? Don't think this is a good idea. > The base address check can't be correct, the > serial device could be the only one in the board and wired to wakeup > but still use a different iobase. We might want to add a check for TARGET_I386, but for x86 it actually _is_ correct as this matches the acpi dsdt information. > One way could be to check if chr == serial_hds[0] or rather, pass the > wakeup reason code from board level based on this check. Wouldn't work. cheers, Gerd
