On 1 September 2012 19:47, Hans de Goede <hdego...@redhat.com> wrote: > Ok, so lets change it to a single underscore if people prefer that.
Why does this function have any kind of starting-with-underscore name at all? The usual reason for a leading underscore is functions in header files or macros where you don't want them to clash with names used by the rest of the program. This is a simple static helper function in one C file -- there's no reason for it not to just have a plain name like any other function. Maybe usb_complete_one_packet() or something. -- PMM