The old code leaks variable 'peer'. Signed-off-by: Stefan Weil <s...@weilnetz.de> --- qemu-sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Report from smatch: qemu-sockets.c:404 inet_dgram_opts(101) warn: variable dereferenced before check 'peer' (see line 401) It looks like this warning does not make sense, but nevertheless it helped me to discover the leak. Regards, Stefan Weil diff --git a/qemu-sockets.c b/qemu-sockets.c index 361d890..037775b 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -353,7 +353,7 @@ int inet_dgram_opts(QemuOpts *opts) if (0 != (rc = getaddrinfo(addr, port, &ai, &local))) { fprintf(stderr,"getaddrinfo(%s,%s): %s\n", addr, port, gai_strerror(rc)); - return -1; + goto err; } /* create socket */ -- 1.7.10