On 08/24/2012 05:10 PM, Andreas Färber wrote:
Am 22.08.2012 14:27, schrieb Julien Grall:
This function permits to retrieve ISA IO address space.
It will be usefull when we need to pass IO address space as argument.

Signed-off-by: Julien Grall<julien.gr...@citrix.com>
---
  hw/isa-bus.c |    5 +++++
  hw/isa.h     |    1 +
  2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/hw/isa-bus.c b/hw/isa-bus.c
index f9b2373..662c86b 100644
--- a/hw/isa-bus.c
+++ b/hw/isa-bus.c
@@ -244,4 +244,9 @@ MemoryRegion *isa_address_space(ISADevice *dev)
      return get_system_memory();
  }

+MemoryRegion *isa_address_space_io(ISADevice *dev)
+{
+    return get_system_io();
+}
Unlike the address_space above, there's an address_space_io field in
ISABus, so I guess the implementation of this function should rather
obtain the device's BusState via isa_bus_from_device(dev) and return its
field rather than hardcoding get_system_io() here.
I use this function in hw/dma.c. For the moment, the code doesn't
use ISA device, so I pass NULL to isa_address_space_io
(See patch 6).

Instead of using isa_bus_from_device, can I just return
"isabus->address_space_io" as in isa_register_portio_list ?

--
Julien Grall

Reply via email to