On 08/23/2012 06:42 AM, Benoît Canet wrote: > This option --output=[human|json] make qemu-img info output on > human or JSON representation at the choice of the user. >
> +static int img_info(int argc, char **argv)
> +{
> + int c;
> + bool human = false, json = false;
I'm still not convinced why we need two booleans, when one would do. If
we ever add a third output type, it would be better to use an enum (0,
1, 2), rather than three separate bools.
>
> +#undef PRINTH
> +
Where did this come from? Other than that, the rest of the series seems
okay for 1.3 from my viewpoint.
--
Eric Blake ebl...@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
