On 08/15/2012 08:54 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet <ben...@irqsave.net> > --- > qapi-schema.json | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 8d4df19..488da90 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -150,6 +150,39 @@ > 'vm-clock-sec': 'int' } } > > ## > +# @ImageInfo: > +# > +# Information about a QEMU image file > +# > +# @filename: name of the image file > +# > +# @format: format of the image file > +# > +# @dirty-flag: true if image is not cleanly closed > +# > +# @cluster-size: size of a cluster in bytes > +# > +# @encrypted: true if the image is encrypted > +# > +# @actual-size: actual size on disk in bytes of the image > +# > +# @virtual-size: maximum capacity in bytes of the image > +# > +# @backing-filename: name of the backing file
Should this be #optional, in the case where there is no backing file? Missing @backing-filename-format, when that is recorded (as long as we're going for machine-parseable, print everything useful, even if qemu-img info doesn't print it right now). Definitely #optional, since it won't be present when @backing-filename is missing, and even when a backing file name is present, the format might not have been recorded. > +# > +# @snapshots: list of VM snapshots Should this be #optional, in the case where there are no snapshots? > +# > +# Since: 1.3 So no way it will make 1.2 hard freeze today :) -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
