Eric Blake <ebl...@redhat.com> wrote: > On 08/13/2012 04:50 AM, Juan Quintela wrote: >> For now this is a placeholder, real info will appear once the bitmap >> changes in the migration thread series is integrated. >> >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> --- >> hmp.c | 4 ++++ >> migration.c | 2 ++ >> migration.h | 1 + >> qapi-schema.json | 6 +++++- >> 4 files changed, 12 insertions(+), 1 deletion(-) >> >> # >> +# @dirty-pages-rate: number of pages dirtied by second by the >> +# guest. (since 1.2) > > Inconsistent on whether we have a '.' prior to the (since 1.2) marking. > > Since HMP only prints this stat when it is non-zero, should this field > be marked optional? Then again, once you have dirty page tracking, I > suspect this would never be zero (or even showing an explicit zero would > help detect stalls).
What is easier for libvirt to have here. At the beggining, this value is going to be wrong/cero. I can: - not print it until it is != 0 - print a big enough number ) - make it optional? I guess this would alse be more difficult for libvirt. - put your good idea here? Later, Juan.
