On Sat, 11 Aug 2012 09:05:33 +0200 Markus Armbruster <arm...@redhat.com> wrote:
> Luiz Capitulino <lcapitul...@redhat.com> writes: > > [...] > > This series implements the 'Plan for error handling in QMP' as described > > by Anthony in this email: > > > > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg03764.html > > > > Basically, this replaces almost all error classes by GenericError (the > > exception are a few error classes used by libvirt) and drops the error > > data memeber. This also adds a free form string to error_set(). > > > > On the wire, we go from: > > > > { "error": { "class": "DeviceNotRemovable", > > "data": { "device": "virtio0" }, > > "desc": "Device 'virtio0' is not removable" } } > > > > to: > > > > { "error": { "class": "GenericError", > > "desc": "Device 'virtio0' is not removable" } } > > > > Internally, we go from: > > > > void error_set(Error **err, const char *fmt, ...); > > > > to: > > > > void error_set(Error **err, ErrorClass err_class, const char *fmt, ...); > > Glad to see this change in good shape in time for the release. Thanks, > Luiz! Thank you for your review! > > Reviewed-by: Markus Armbruster <arm...@redhat.com> >
