On 2012年08月07日 20:19, Christian Borntraeger wrote:
2nd attempt, with mailing lists on cc....
This patch reminded us of another thing that we have been working on.
Here is a patch that sits in my patch queue and disables usb for s390
We have not pushed that patch yet, since several libvirt versions will always
specify -usb, which will then break.
So are there any opinions about handling the usb option for platforms that
actually dont support it?
My patches removed the usb_enabled global variable.
So platforms can't use the global variable any more.
Platforms created usb controller according to usb_enabled global
variable before.
Now we add USB option to machine options.
For the platfrom, usb_enabled is got from machine option as the following:
QemuOpts *mach_opts;
bool usb_enabled = false; (If the platform needs to default value as
true, it should be set as true )
mach_opts = qemu_opts_find(qemu_find_opts("machine"), 0);
if (mach_opts) {
usb_enabled = qemu_opt_get_bool(mach_opts, "usb", false);
}
Christian
-
Eugene Dvurechenski (1):
USB code fenced for s390
configure | 66 +++++++++++++++++++++++++++++++++++++++++------------
hmp-commands.hx | 6 +++++
hw/Makefile.objs | 5 ++-
monitor.c | 4 +++
qemu-options.hx | 4 +++
sysemu.h | 2 +
vl.c | 8 +++++-
7 files changed, 76 insertions(+), 19 deletions(-)
--
Li Zhang
IBM China Linux Technology Centre
