On Thu, 02 Aug 2012 15:57:24 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote:
> Il 02/08/2012 15:53, Markus Armbruster ha scritto: > >> > Is this anything that an external application can reproduce? > >> > > >> > Perhaps we need to keep QERR_DEVICE_ENCRYPTED even if libvirt does not > >> > use it, or at least provide an alternative mechanism (e.g. an event) to > >> > realize its effect. > > Not sure I get you. > > > > External applications should use QMP. > > Yes. Is there a conceivable scenario in which a QMP client needs to > look at QERR_DEVICE_ENCRYPTED? > > > A sane way to change media in QMP needs to provide the key as argument. > > How does the QMP client know that the device is encrypted, and thus they > have to ask for the key and retry? It would be interesting to know how libvirt handles this. > > Same for hmp_cont, by the way. > > > If the key is wrong, fail the change cleanly. In particular, don't > > eject then. > > Agreed on not ejecting, but this is orthogonal. > > Paolo >
