Andreas Färber <afaer...@suse.de> writes: > Am 01.08.2012 22:02, schrieb Anthony Liguori: >> Andreas Färber <afaer...@suse.de> writes: >> >>> Am 01.08.2012 20:25, schrieb Anthony Liguori: >>>> Andreas Färber <afaer...@suse.de> writes: >>>> >>>>> Am 01.08.2012 17:43, schrieb Anthony Liguori: >>>>>> Igor Mammedov <imamm...@redhat.com> writes: >>>>>> >>>>>>> v2: >>>>>>> ommited moving of x86_cpu_realize() from cpu_x86_init() to >>>>>>> pc_new_cpu(), >>>>>>> to keep cpu_init implementation in -softmmu and -user targets the same >>>>>>> in single place and maintanable. >>>>>>> >>>>>>> v3: >>>>>>> reuse cpu_is_bsp() rather than open code check if apicbase has BSP >>>>>>> bit set >>>>>>> >>>>>>> tree for testing: >>>>>>> https://github.com/imammedo/qemu/tree/x86_reset_v3 >>>>>>> >>>>>>> comiple & run tested with x86_64-linux-user, x86_64-softmmu targets >>>>>>> >>>>>>> Igor Mammedov (2): >>>>>>> target-i386: move cpu halted decision into x86_cpu_reset >>>>>>> target-i386: move cpu_reset and reset callback to cpu.c >>>>>> >>>>>> Applied all. Thanks. >>>>> >>>>> So do you intend to refactor all machines accordingly or leave it >>>>> inconsistent now? >>>> >>>> Are you asking me? >>>> >>>> No, I have no intention of touching any other machine. We're not going >>>> to limit cleaning up target-i386 unless every other machine is cleaned >>>> up too. >>>> >>>> Reset logic should live in the CPU. Seems like a no-brainer to me. >>> >>> Yes, I'm asking you, since you replied and applied the series without >>> responding to my review comment on patch 2/2. You probably applied it >>> locally before reading my comments but then I would still have expected >>> a reply on how to proceed in light of those comments: >> >> No, I saw your comment, although I had already decided to apply it by >> then. > > If you did read it then you forgot my Reviewed-by on 1/2. :(
Oh, sorry, I switched to a new patch apply script. Maybe it's not working correctly. I'll look into it. Regards, Anthony Liguori > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
