On Tue, Jul 17, 2012 at 10:49 AM, Catalin Patulea <catal...@google.com> wrote: > > the Windows build would not put the fields 'mantissa' and > > 'one' in the same 64 bit word, it would insert a padding bit. > Since floatx80 is not part of a Windows API (in fact, it's not part of > any API, it's in a test), could I give the structs an attribute of > "gcc_struct"? I just noticed that QEMU_PACKED includes this attribute whenever it is needed (#if defined(_WIN32)) since Stefan Weil's 0f7fdd347514ea97b24f5f658f3ae31f9b078397. Would making the float80u structs QEMU_PACKED be a reasonable solution? Stefan, can you comment on whether this is an appropriate use of QEMU_PACKED?
Are there any other issues with the patch? I would punt on the numeric underflow issue (leaving a TODO), because I think even without it, adding this test to the codebase is a significant improvement over what's there currently. Also, ultimately, this is just a safety net for my patch which changes the FPREM implementation, so I would want to use the testing patch to make progress there.
