Re: [Qemu-devel] [PATCH] cpu-defs.h: pull in qemu-common.h for HOST_LONG_BITS

[Stefan Weil]

Am 15.07.2012 22:25, schrieb Mike Frysinger:

This file uses the define HOST_LONG_BITS, but doesn't explicitly include
qemu-common.h for it leading to build warnings for some setups:
In file included from qemu/target-bfin/cpu.h:17,
                  from qemu/cputlb.c:21:
qemu/cpu-defs.h:83:5: warning: "HOST_LONG_BITS" is not defined

Signed-off-by: Mike Frysinger <vap...@gentoo.org>
---
  cpu-defs.h |    1 +
  1 file changed, 1 insertion(+)

diff --git a/cpu-defs.h b/cpu-defs.h
index f49e950..0d6018d 100644
--- a/cpu-defs.h
+++ b/cpu-defs.h
@@ -28,6 +28,7 @@
  #include <inttypes.h>
  #include <signal.h>
  #include "osdep.h"
+#include "qemu-common.h"
  #include "qemu-queue.h"
  #include "targphys.h"

No. Of course this works, but I don't think that it is reasonable
to include qemu-common.h in every *.h file. There are already too
many of them.

target-bfin/cpu.h should start like all other cpu.h files with
these include statements:

#include "config.h"
#include "qemu-common.h"

Regards,

Stefan Weil