Am 06.07.2012 15:50, schrieb Alexander Graf:
>
> On 02.07.2012, at 07:25, zhlci...@gmail.com wrote:
>
>> @@ -712,6 +730,11 @@ static void ppc_spapr_init(ram_addr_t ram_size,
>> spapr_vscsi_create(spapr->vio_bus);
>> }
>>
>> + /* Graphics */
>> + if (spapr_vga_init(QLIST_FIRST(&spapr->phbs)->host_state.bus)) {
>> + spapr_has_graphics = true;
>> + }
>
> How about
>
> spapr_has_graphics = spapr_vga_init(...);
>
> If that gets you above 80 characters, just shove the parameter to
> spapr_vga_init into a variable.
Further, that expression could use
PCIHostState *phb = PCI_HOST_BRIDGE(QLIST_FIRST(&spapr->phbs));
spapr_vga_init(phb->bus)
once introduced through the pci_host series. :)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
