----- Original Message ----- > Michael Tokarev <m...@tls.msk.ru> writes: > > > On 06.07.2012 06:42, Amos Kong wrote: > >> On 30/06/12 10:02, ak...@redhat.com wrote: > >>> From: Amos Kong <ak...@redhat.com> > >>> > >>> Currently qemu outputs some low-level error in qemu-sockets.c > >>> when failed to start vnc server. > >>> eg. 'getaddrinfo(127.0.0.1,5902): Name or service not known' > >>> > >>> Some libvirt users could not know what's happened with this > >>> unclear error message. This patch added a more descriptive > >>> error message. > > Only libvirt users? Really?
Actually, it's not clear for all users. > > Gyus, please, pretty PLEASE stop doing things like this. > > > > Amos, your patch does TWO things. One is to clarify error > > message as correctly stated in your description, and second > > is to change the code to do exit(1) if this message is > > generated. So, please, a) add the second fact to the > > description, and b) mention why it is needed. 'exit(1)' is the original code, my patch just add an error message. > Seconded. Thanks, Amos.
