the fix is correct, thanks!
something more to improve:
On Thu, Mar 26, 2026 at 01:19:47PM +0100, Heinrich Schuchardt wrote:
> On LoongArch and RISC-V invalid SPCR tables are created:
>
> Terrminal Type : 00
> Language : 03
>
> The correct values are:
>
> Terrminal Type : 03
> Language : 00
>
> This is due to commit 7dd0b070fa09 ("hw/arm/virt-acpi-build.c: Migrate
> SPCR creation to common location") that swapped the fields.
>
> See the specification of the table in
> https://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/serial-port-console-redirection-table
should mention revision you are consulting.
>
> Fixes: 7dd0b070fa09 ("hw/arm/virt-acpi-build.c: Migrate SPCR creation to
> common location")
> Signed-off-by: Heinrich Schuchardt <[email protected]>
BTW I think the link to the spec should move to build_spcr.
And also:
/*
* Serial Port Console Redirection Table (SPCR)
* Rev: 1.07
*/
is probably wrong:
1.07 Fixed incorrect description in Stop Bits field. Undo accidental removal
of Flow Control field. Edited formatting.
it's likely not the earliest version we adhere to.
> ---
> hw/acpi/aml-build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 4b37405088..a999320e61 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -2115,10 +2115,10 @@ void build_spcr(GArray *table_data, BIOSLinker
> *linker,
> build_append_int_noprefix(table_data, f->stop_bits, 1);
> /* Flow Control */
> build_append_int_noprefix(table_data, f->flow_control, 1);
> - /* Language */
> - build_append_int_noprefix(table_data, f->language, 1);
> /* Terminal Type */
> build_append_int_noprefix(table_data, f->terminal_type, 1);
> + /* Language */
> + build_append_int_noprefix(table_data, f->language, 1);
> /* PCI Device ID */
> build_append_int_noprefix(table_data, f->pci_device_id, 2);
> /* PCI Vendor ID */
> --
> 2.53.0
