Am 10.03.26 um 7:35 PM schrieb Michael Tokarev: > On 10.03.2026 19:22, Fiona Ebner wrote: >> Am 08.03.26 um 9:24 AM schrieb Michael Tokarev: >>> On 19.02.2026 23:24, Kevin Wolf wrote:...>> While trying to apply >>> this one to 10.0.x series of qemu, I noticed there >>> are a few other commits missing in this area. Namely, these commits are >>> missing in there: >>> >>> 91ba0e1c382bd4 block: move drain outside of bdrv_change_aio_context() >>> and mark GRAPH_RDLOCK >>> ffdcd081f52544 block: move drain outside of bdrv_root_attach_child() >>> 6b89e851fabf78 block: add bdrv_graph_wrlock_drained() convenience >>> wrapper >>> >>> This is just a context, but I wonder if the resulting thing look sane. >>> https://gitlab.com/mjt0k/qemu/-/ >>> commit/04c53bdbef634f93ac4149a19bf2de2e8d156b2b -- >>> can you take a look please? >> >> FWIW, it looks fine to me :) The fix here should be orthogonal to the >> draining changes from those commits. > > Thank you very much for looking at this one. > > Since you're the one who wrote the above mentioned draining commits, > how do you think, should these be picked up for stable-10.0? > (I tried, it gets quite a bit messy there, but it seems like they're > fixing real issues).
Yes, they do fix real deadlocks, but only in some rare, racy edge cases. I can imagine that it might get messy, since that patch series essentially touched all of the block layer and is doing lots of incremental changes. I honestly do not know if it would be worth the effort. Best Regards, Fiona
