On 3/7/26 11:46, Peter Maydell wrote:
On Fri, 6 Mar 2026 at 20:40, Helge Deller <[email protected]> wrote:
* Peter Maydell <[email protected]>:
You need to increment the version_id and minimum_version_id
to change the vmstate. Or you could instead replace the line with
VMSTATE_UNUSED(1), /* was "disable" */
(which keeps the migration data structure the same, so no
version bump needed).
I have no strong preference; I would probably just bump
the version numbers personally.
New patch below.
Ok?
Helge
From: Helge Deller <[email protected]>
Subject: [PATCH] hw/char: Drop disable property of Diva GSP card
The "disable" property is not used, so drop it.
Noticed-by: Peter Maydell <[email protected]>
Signed-off-by: Helge Deller <[email protected]>
That looks fine, you can have
Reviewed-by: Peter Maydell <[email protected]>
Thanks!
(You should send these to the list as proper patchmails.)
Yes, I'll include them in my next pull request and then
they will show up as normal stand-alone patches.
Helge
