Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

[Anthony Liguori]

On 06/17/2012 03:34 AM, Michael S. Tsirkin wrote:
On Sun, Jun 17, 2012 at 06:26:33AM +0000, Ma, Stephen B. wrote:

Michael,

Thanks for the review.  I added the unparent to the qdev_free.


---
  hw/qdev.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/qdev.c b/hw/qdev.c
index d2dc28b..ed1328d 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -264,6 +264,7 @@ void qdev_init_nofail(DeviceState *dev)
  /* Unlink device from bus and free the structure.  */
  void qdev_free(DeviceState *dev)
  {
+    object_unparent(OBJECT(dev));
      object_delete(OBJECT(dev));
  }

--
1.7.1

Anthony, any feedback?

Yes, this is wrong.

PCI passthrough isn't in qemu.git so it's not clear to me where this is 
happening.  Why would qdev_free be called when adding a PCI passthru device?

Regards,

Anthony Liguori