On 11 June 2012 08:13, Andreas Färber <afaer...@suse.de> wrote: > Am 05.06.2012 12:00, schrieb Peter Maydell: >> I don't think this is a fantastic idea -- the device struct should be >> private to the device, and having it in a standalone header file is >> asking for users of the device to illicitly include it and access >> internals that they shouldn't. > > But that is exactly where realize is headed. PCIBus, a9mp_priv etc. > structs will need to be made public so that they can be embedded.
I think that's a bad thing -- our object model shouldn't require all that stuff to be publicly visible. Qdev/sysbus doesn't need it to be publicly visible at the moment, and we shouldn't go backwards. -- PMM
