Hi,
> + if (d->fb_size < fb) {
> + d->fb_size = fb;
> + }
> + if (fb <= d->fb_size) {
This check doesn't make sense, it will always be true.
> + if (qxl->fb_size_mb != -1 &&
> + qxl->fb_size_mb * 1024 * 1024 < qxl->vga.vram_size) {
> + qxl->fb_size = qxl->fb_size_mb * 1024 * 1024;
> + } else {
> + qxl->fb_size = VGA_RAM_SIZE;
> + }
Reminds me that I have some pending work to make vga ram size
configurable which I should finish and repost ...
Current state pushed to http://www.kraxel.org/cgit/qemu/log/?h=vga.1
It probably makes sense to base this on top.
> + DEFINE_PROP_UINT32("fb_size_mb", PCIQXLDevice, fb_size_mb, -1),
Maybe also rename this to vgamem_mb for consistency with standard vga.
cheers,
Gerd
