On 08/12/2025 10.11, Daniel P. Berrangé wrote:
On Fri, Dec 05, 2025 at 12:48:25PM +0000, Alex Bennée wrote:
Thomas Huth <[email protected]> writes:

On 04/12/2025 20.48, Alex Bennée wrote:
Technically we don't need a crypto library to do the base build but
I couldn't see an easy way to skip iotests which would otherwise fail.
Besides libnettle is a fairly small library even if its not the
fastest crypto implementation.

I think we added checks to some of the iotests in the past already to
skip if the crypto stuff is not available? So I think it might be
better to fix the related iotests instead.

We have _require_working_luks called by "_supported_fmt luks"
in the shell tests, and iotests.verify_working_luks called
in the python tests. Possibly we didn't call them in all the
required places ? Or there is a non-luks related test that
uses crypto we missed ?

It's about non-luks related tests, see the patch here:

https://lore.kernel.org/qemu-devel/[email protected]/T/#t

 Thomas


Reply via email to