On Mon, Jun 4, 2012 at 9:36 AM, Kevin Wolf <kw...@redhat.com> wrote: > Am 03.06.2012 19:38, schrieb Blue Swirl: >> Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF >> (for implemented cases) or to use LOG_UNIMP (unimplemented). >> >> Signed-off-by: Blue Swirl <blauwir...@gmail.com> > > I would suggest that you check the messages of those cases that became > FLOPPY_DPRINTF(). Originally the macro printed "FLOPPY ERROR: " and now > it's not even mentioned any more that it is an error message, making > messages like "writing sector %d" totally misleading.
Is that an error condition at all? It looks like just debugging. > > If you fix that up: > > Acked-by: Kevin Wolf <kw...@redhat.com>
