On Tue, Jun 05, 2012 at 12:52:02AM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2012 at 04:15:56PM -0400, Jason Baron wrote: > > On Sun, May 20, 2012 at 05:57:45PM +0800, Amos Kong wrote: > > > Start VM with 8 multiple-function block devs, hot-removing > > > those block devs by 'device_del ...' would cause qemu abort. > > > > > > | (qemu) device_del virti0-0-0 > > > | (qemu) ** > > > |ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0) > > > > > > It's a regression introduced by commit 57c9fafe > > > > > > > I found a similar assertion where the parent reference isn't cleared, > > doing: > > > > (qemu) device_add pci-bridge > > > > in the monitor. I posted for patches for it under: > > > > Subject: [Qemu-devel] [PATCH 0/2] pci: hotplug bridge fixes > > > > It's still an issue with the current tree. > > > > Thanks, > > > > -Jason > > I pushed your patches on my tree pci branch, care to test > there? >
Yes, fixes are confirmed. Test case is quite simple: (qemu) device_add pci_bridge causes segfault without the 2 patches applied. Thanks, -Jason
