Peter Maydell <peter.mayd...@linaro.org> writes:
> On 5 June 2012 13:51, Markus Armbruster <arm...@redhat.com> wrote:
>> @@ -554,6 +553,7 @@ static int blk_init(struct XenDevice *xendev)
>> {
>> struct XenBlkDev *blkdev = container_of(xendev, struct XenBlkDev,
>> xendev);
>> int index, qflags, info = 0;
>> + char fmt_name[128];
>
> Fixed length array with a hardcoded magic number size ?
> If the block layer guarantees that format names are going to be
> less than 128 bytes it ought to provide a suitable #define for
> people to set array sizes to...
Maybe it should, but it doesn't. Does it really matter in this
particular case? If somebody insists on giving his driver a name longer
than 127 characters, we'll silently log it truncated, that's all.
