Am 01.06.2012 05:23, schrieb Peter A. G. Crosthwaite: > Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwa...@petalogix.com> > --- > changed from v3: > simplified tcg local variable usage aqcross branch > changed from v2: > fixed tcg local variable usage across branch > reworked carry logic (with new write_carryi() function) > made LOG_DIS show lwx swx properly > changed from v1: > implemented reservation address checking > created new cpu state variable specifically for reservation address/flag state > > target-microblaze/cpu.c | 1 + > target-microblaze/cpu.h | 4 ++ > target-microblaze/helper.c | 2 + > target-microblaze/translate.c | 62 +++++++++++++++++++++++++++++++++++++--- > 4 files changed, 64 insertions(+), 5 deletions(-) > > diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c > index 9c3b74e..34b3a9b 100644 > --- a/target-microblaze/cpu.c > +++ b/target-microblaze/cpu.c > @@ -39,6 +39,7 @@ static void mb_cpu_reset(CPUState *s) > mcc->parent_reset(s); > > memset(env, 0, offsetof(CPUMBState, breakpoints)); > + env->res_addr = RES_ADDR_NONE; > tlb_flush(env, 1); > > /* Disable stack protector. */
Note that my idea for structuring mb_cpu_reset() was to group the "duplicated common" functionality there that would get moved into the base class' reset function once no longer dependent on "env". Not a blocker for this patch but if you have to send a v2 anyway. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg