On Sat, 30 Aug 2025 at 17:05, Richard Henderson <richard.hender...@linaro.org> wrote: > > Based on Peter's tags/pull-target-arm-20250828. > Tree: https://gitlab.com/rth7680/qemu/-/tree/tgt-arm-gcs > > This includes the prerequisite features, ATS1A and S1PIE, and > not a prerequisite but closely related, S2PIE. > > This passes the linux kselftests for gcs, with a 48-bit VA. > I also include a few smoke tests in tests/tcg/. > > > This includes a best-effort linux-user implementation. Since we > don't have softmmu in user-only (yet), gcs stack pages get normal > read/write access. This means we cannot write-protect the pages > in the same way the system implementation can. But all of the > other parts of GCS work fine, which is good enough for testing. > > Changes for v4: > - Rebase on target-arm.next, which includes all prereqs. > - Fixes up the minor conflicts with the elfload.c split. > - Include Thiago's t-b on the system-mode enable patch.
I've now gone through this patchset. I haven't sent R-by tags because I didn't do very close inspection and other people have already done review (thanks!). I have left comments on some patches where I saw issues: 21, 26, 50, 52, 53, 68, but the rest looked good to me. I've applied patches 1-12 to target-arm.next (the FEAT_ATS1A part). Unfortunately the first major review issue is in patch 21 so I couldn't take up to FEAT_S1PIE/FEAT_S2PIE :-( thanks -- PMM
