On 01/09/2025 16:22, Markus Armbruster wrote:
Mark Cave-Ayland <mark.caveayl...@nutanix.com> writes:
Now that the isapc logic has been split out of pc_piix.c, the PCI Host Bridge
(phb) object is now always set in pc_init1().
Since phb is now guaranteed not to be NULL, Coverity reports that the if()
statement surrounding ioapic_init_gsi() is now unnecessary and can be removed
(CID 1620557), along with the phb NULL initialiser.
We commonly use the more formal tag
Coverity: CID 1620557
Signed-off-by: Mark Cave-Ayland <mark.caveayl...@nutanix.com>
Fixes: 99d0630a45 ("hw/i386/pc_piix.c: assume pcmc->pci_enabled is always true in
pc_init1()")
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Thanks Markus, I've just posted a v3 with this added.
ATB,
Mark.
