On Thu, Aug 28, 2025 at 11:47:23AM -0400, Andrew Keesler wrote: > > > I think we should probably report an error if xres / yres > > > are set at the global level and also set against any individual > > > output, so the two approaches are mutually exclusive. > > > ACK - fixed for the next patch. > > Doh, I ran into an error. Seems like if I don't set xres/yres, then it > gets defaulted to 1280x800. > > > https://gitlab.com/qemu-project/qemu/-/blob/master/include/hw/virtio/virtio-gpu.h#L175-176 > > So...could we just get away with documenting that if you set xres/yres > and outputs[0].xres/yres, then the later is going to overwrite the > former? I'm not sure how to detect if xres/yres has been set globally > to 1280x800, or if we are just getting the defaults. > > What do you think?
Oh it probably isn't worth the hassle for a mere error report. Instead just document that per-output takes priority if both are set. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
