RE: [PATCH v5 01/21] intel_iommu: Rename vtd_ce_get_rid2pasid_entry to vtd_ce_get_pasid_entry

[Duan, Zhenzhong]

>-----Original Message-----
>From: Nicolin Chen <nicol...@nvidia.com>
>Subject: Re: [PATCH v5 01/21] intel_iommu: Rename
>vtd_ce_get_rid2pasid_entry to vtd_ce_get_pasid_entry
>
>On Fri, Aug 22, 2025 at 02:40:39AM -0400, Zhenzhong Duan wrote:
>> In early days vtd_ce_get_rid2pasid_entry() was used to get pasid entry
>> of rid2pasid, then it was extended to get any pasid entry. So a new name
>> vtd_ce_get_pasid_entry is better to match what it actually does.
>>
>> No functional change intended.
>>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com>
>> Reviewed-by: Clément Mathieu--Drif<clement.mathieu--d...@eviden.com>
>> Reviewed-by: Yi Liu <yi.l....@intel.com>
>> Reviewed-by: Eric Auger <eric.au...@redhat.com>
>
>Reviewed-by: Nicolin Chen <nicol...@nvidia.com>
>
>> @@ -944,7 +944,7 @@ static int
>vtd_get_pe_from_pasid_table(IntelIOMMUState *s,
>>      return 0;
>>  }
>>
>> -static int vtd_ce_get_rid2pasid_entry(IntelIOMMUState *s,
>> +static int vtd_ce_get_pasid_entry(IntelIOMMUState *s,
>>                                        VTDContextEntry *ce,
>>                                        VTDPASIDEntry *pe,
>>                                        uint32_t pasid)
>
>Nit: it could be re-organized a bit with the shrunk indentation.

Good catch, will do.

Thanks
Zhenzhong