Hi Richard, > On 8/20/25 04:21, Kohei Tokunaga wrote: > > This commit implements andc, orc, eqv, nand and nor operations using Wasm > > instructions. > > > > Signed-off-by: Kohei Tokunaga <ktokunaga.m...@gmail.com> > > --- > > tcg/wasm/tcg-target.c.inc | 55 +++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > > diff --git a/tcg/wasm/tcg-target.c.inc b/tcg/wasm/tcg-target.c.inc > > index 01ef7d32f3..3c0374cd01 100644 > > --- a/tcg/wasm/tcg-target.c.inc > > +++ b/tcg/wasm/tcg-target.c.inc > > @@ -449,6 +449,56 @@ static void tcg_wasm_out_cond( > > } > > } > > > > +static void tcg_wasm_out_andc( > > + TCGContext *s, TCGReg ret, TCGReg arg1, TCGReg arg2) > > +{ > > + tcg_wasm_out_op_idx(s, OPC_GLOBAL_GET, REG_IDX(arg1)); > > + tcg_wasm_out_op_idx(s, OPC_GLOBAL_GET, REG_IDX(arg2)); > > + tcg_wasm_out_op_not(s); > > + tcg_wasm_out_op(s, OPC_I64_AND); > > + tcg_wasm_out_op_idx(s, OPC_GLOBAL_SET, REG_IDX(ret)); > > +} > > Don't implement stuff that's not present in the ISA. > This will be handled generically.
Thank you for the feedback. I'll remove them and rely on the default expansion. Regards, Kohei