Peter Xu <pet...@redhat.com> writes: > On Mon, Jun 30, 2025 at 04:59:09PM -0300, Fabiano Rosas wrote: >> Allow the migrate and migrate_incoming commands to pass the migration >> configuration options all at once, dispensing the use of >> migrate-set-parameters and migrate-set-capabilities. >> >> The motivation of this is to simplify the interface with the >> management layer and avoid the usage of several command invocations to >> configure a migration. It also avoids stale parameters from a previous >> migration to influence the current migration. >> >> The options that are changed during the migration can still be set >> with the existing commands. >> >> The order of precedence is: >> >> 'config' argument > -global migration cmdline > migrate-set-parameters >> > defaults (migration_properties) > > Did you make the 2nd/3rd the wrong way? > > config > migrate-set-parameters > -global cmdlines > defaults >
Good catch. Thanks! >> >> I.e. the config takes precedence over all, values not present in the >> config assume the default values. The -global migration command line >> option allows the defaults to be overridden for debug. >> >> Signed-off-by: Fabiano Rosas <faro...@suse.de> > > Other than that: > > Reviewed-by: Peter Xu <pet...@redhat.com>
