On Fri, Aug 8, 2025 at 2:35 AM Markus Armbruster <arm...@redhat.com> wrote: > > John Snow <js...@redhat.com> writes: > > > On Thu, Jul 31, 2025 at 1:40 AM Markus Armbruster <arm...@redhat.com> wrote: > >> > >> The new QAPI code generator creates a cross-reference target for each > >> definition documentation. Enabled for the QEMU QMP Reference manual > >> in commit a377f39f38f, and for the QEMU Storage Daemon QMP Reference > >> Manual and the QEMU Guest Agent Protocol Reference in commit > >> a6af5443440. We've put these targets to use since, but neglected to > >> update doc comment markup documentation. Do that now. > >> > >> Co-developed-by: John Snow <js...@redhat.com> > > > > No need for this in my opinion, the SOB suffices to say the same thing > > in my book. I don't insist you remove it, just seems ... oddly > > pretentious to say I "co-developed" a single paragraph of text ;) > > It wasn't obvious to me how to best credit you, so I tried this. The > Co-developed-by serves as an explanation why your S-o-b is there. > > Please pick one: > > 1. Do nothing.
You're on vacation now, so by process of elimination, we'll do this ;) > > 2. Delete Co-developed-by. > > 3. Delete Co-developed-by, your Signed-off-by, add your Reviewed-by. > > >> Signed-off-by: John Snow <js...@redhat.com> > >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > > > Reviewed-by: John Snow <js...@redhat.com> > > Thanks! >
