Hi
On Fri, Aug 8, 2025 at 12:08 PM Markus Armbruster <arm...@redhat.com> wrote:
> net_slirp_register_poll_sock() and net_slirp_unregister_poll_sock()
> report WSAEventSelect() failure with error_setg(&error_warn, ...).
>
> I'm not familiar with liblirp, so I can't say whether the network
> backend will work after such a failure. If it doesn't, then this
> should be an error. If it does, then why bother the user with a
> warning that isn't actionable, and likely confusing?
>
I don't know if this is recoverable either. It's probably not if the handle
is invalid. I guess you could turn it into a non-fatal error.
>
> Regardless of that, error_setg_win32(&error_warn, ...) is undesirable
> just like error_setg(&error_fatal, ...) and error_setg(&error_abort,
> ...) are. Replace by warn_report().
>
> Cc: Marc-André Lureau <marcandre.lur...@redhat.com>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>
lgtm, thanks
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> net/slirp.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index 9657e86a84..d75b09f16b 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -262,7 +262,8 @@ static void
> net_slirp_register_poll_sock(slirp_os_socket fd, void *opaque)
> if (WSAEventSelect(fd, event_notifier_get_handle(&ctxt->notifier),
> FD_READ | FD_ACCEPT | FD_CLOSE |
> FD_CONNECT | FD_WRITE | FD_OOB) != 0) {
> - error_setg_win32(&error_warn, WSAGetLastError(), "failed to
> WSAEventSelect()");
> + warn_report("failed to WSAEventSelect(): %s",
> + g_win32_error_message(WSAGetLastError()));
> }
> #endif
> }
> @@ -271,7 +272,8 @@ static void
> net_slirp_unregister_poll_sock(slirp_os_socket fd, void *opaque)
> {
> #ifdef WIN32
> if (WSAEventSelect(fd, NULL, 0) != 0) {
> - error_setg_win32(&error_warn, WSAGetLastError(), "failed to
> WSAEventSelect()");
> + warn_report("failed to WSAEventSelect()",
> + g_win32_error_message(WSAGetLastError()));
> }
> #endif
> }
> --
> 2.49.0
>
>
