watch_add() reports _open_osfhandle() failure with
error_setg(&error_warn, ...).
I'm not familiar with Spice, so I can't say whether it will work after
such a failure. If it doesn't, then this should be an error. If it
does, then why bother the user with a warning that isn't actionable,
and likely confusing?
Regardless of that, error_setg_win32(&error_warn, ...) is undesirable
just like error_setg(&error_fatal, ...) and error_setg(&error_abort,
...) are. Replace by warn_report().
Cc: Marc-André Lureau <marcandre.lur...@redhat.com>
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
ui/spice-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 5992f9daec..97bdd171cd 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -132,7 +132,8 @@ static SpiceWatch *watch_add(int fd, int event_mask,
SpiceWatchFunc func, void *
#ifdef WIN32
fd = _open_osfhandle(fd, _O_BINARY);
if (fd < 0) {
- error_setg_win32(&error_warn, WSAGetLastError(), "Couldn't associate a
FD with the SOCKET");
+ warn_report("Couldn't associate a FD with the SOCKET: %s"
+ g_win32_error_message(WSAGetLastError()));
return NULL;
}
#endif
--
2.49.0
