On 2025/08/07 19:31, Laurent Vivier wrote:
Removing totally the "if (msix_enabled(core->owner))" could introduce a
behavior change in the current implementation and I'd like to avoid that.
I failed to respond to this. There will be no behavioral change other
than getting rid of the assertion failure.
If core->delayed_causes == 0, the latter part of this function is no-op
and just returns 0. This is no different whether
"if (msix_enabled(core->owner))" is present or not.
If core->delayed_causes != 0, we had the assertion failure, but the
assertion failure will be gone. The behavior after assert() was never
present in the past, so we don't have to worry about behavioral change.
Regards,
Akihiko Odaki