Re: [PATCH v3 09/12] semihosting/arm-compat-semi: replace target_ulong with uint64_t

[Philippe Mathieu-Daudé]

Hi Pierrick,

On 4/8/25 20:39, Pierrick Bouvier wrote:

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
---
  semihosting/arm-compat-semi.c | 24 ++++++++++++------------
  1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
index c03096b253d..f593239cc9a 100644
--- a/semihosting/arm-compat-semi.c
+++ b/semihosting/arm-compat-semi.c
@@ -123,7 +123,7 @@ static GuestFD console_out_gf;
   */

typedef struct LayoutInfo {

-    target_ulong rambase;
+    vaddr rambase;

Subject says uint64_t but code use vaddr, is that expected?

      size_t ramsize;
      hwaddr heapbase;
      hwaddr heaplimit;

@@ -300,9 +300,9 @@ static void common_semi_seek_cb(CPUState *cs, uint64_t ret, 
int err)
   * is defined by GDB's remote protocol and is not target-specific.)
   * We put this on the guest's stack just below SP.
   */
-static target_ulong common_semi_flen_buf(CPUState *cs)
+static uint64_t common_semi_flen_buf(CPUState *cs)
  {
-    target_ulong sp = common_semi_stack_bottom(cs);
+    vaddr sp = common_semi_stack_bottom(cs);

Ditto.

      return sp - 64;
  }