On 2012-05-24 07:51, Max Filippov wrote: > On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka <jan.kis...@web.de> wrote: >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> tb_invalidate_phys_addr has to called with the exact physical address of >> the breakpoint we add/remove, not just the page's base address. >> Otherwise we easily fail to flush the right TB. >> >> Regression of 1e7855a558. > > Sorry, I fail to see how 1e7855a558 could introduce a regression, it > just rearranged the code. > Even more, AFAIK cpu_get_phys_page_debug returns complete physical > address, not just > physical page. Probably it has a misleading name.
Unfortunately, cpu_get_phys_page_debug does NOT deliver the sub-page offset, only the page base address. So the regression was caused by this refactoring. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
