On Thu, Jul 17, 2025 at 06:07:37AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
>
> Signed-off-by: Arun Menon <arme...@redhat.com>
> ---
> migration/savevm.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
> diff --git a/migration/savevm.c b/migration/savevm.c
> index
> 6f181c381dc6ecd996a1f8dbc25cceead7ebe014..20dce4b43a181d2f47b6b22e7a15aa4fc45cac5c
> 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2333,12 +2333,12 @@ static void
> migrate_send_rp_req_pages_pending(MigrationIncomingState *mis)
> }
> }
>
> -static int loadvm_postcopy_handle_resume(MigrationIncomingState *mis)
> +static void loadvm_postcopy_handle_resume(MigrationIncomingState *mis)
> {
> if (mis->state != MIGRATION_STATUS_POSTCOPY_RECOVER) {
> error_report("%s: illegal resume received", __func__);
Pre-existing mistake, but can you change this to 'warn_report' given that
we're not treating it as an error.
Aside from that
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
