Re: [PATCH-for-10.1 1/3] accel/hvf: Display executable bit as 'X'

[BALATON Zoltan]

On Thu, 17 Jul 2025, Xiaoyao Li wrote:

On 7/17/2025 1:28 AM, Philippe Mathieu-Daudé wrote:

Developers are custom to read RWX, not RWE.

"accustomed to"

Replace E -> X.

Reported-by: Alex Bennée <alex.ben...@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>

Reviewed-by: Xiaoyao Li <xiaoyao...@intel.com>

---
  accel/hvf/hvf-all.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c
index e67a8105a66..0a4b498e836 100644
--- a/accel/hvf/hvf-all.c
+++ b/accel/hvf/hvf-all.c

@@ -84,7 +84,7 @@ static int do_hvf_set_memory(hvf_slot *slot, hv_memory_flags_t flags)

      trace_hvf_vm_map(slot->start, slot->size, slot->mem, flags,
                       flags & HV_MEMORY_READ ?  'R' : '-',
                       flags & HV_MEMORY_WRITE ? 'W' : '-',
-                     flags & HV_MEMORY_EXEC ?  'E' : '-');
+                     flags & HV_MEMORY_EXEC ?  'X' : '-');
      ret = hv_vm_map(slot->mem, slot->start, slot->size, flags);
      assert_hvf_ok(ret);
      return 0;