On Wed, Jul 16, 2025 at 08:11:39PM +0530, Sunil V L wrote:
> RISC-V support is added only in ACPI 6.6. According to the ACPI 6.6
> specification, the minor version of the Fixed ACPI Description Table
> (FADT) should be 6, and the Multiple APIC Description Table (MADT)
> should use revision 7. So, update the RISC-V FADT and MADT to reflect
> correct versions.
>
> Signed-off-by: Sunil V L <suni...@ventanamicro.com>
> ---
> hw/riscv/virt-acpi-build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c
> index ee1416d264..d7e57cbb1f 100644
> --- a/hw/riscv/virt-acpi-build.c
> +++ b/hw/riscv/virt-acpi-build.c
> @@ -429,7 +429,7 @@ static void build_fadt_rev6(GArray *table_data,
> {
> AcpiFadtData fadt = {
> .rev = 6,
> - .minor_ver = 5,
> + .minor_ver = 6,
> .flags = 1 << ACPI_FADT_F_HW_REDUCED_ACPI,
> .xdsdt_tbl_offset = &dsdt_tbl_offset,
> };
> @@ -537,7 +537,7 @@ static void build_madt(GArray *table_data,
>
> hart_index_bits = imsic_num_bits(imsic_max_hart_per_socket);
>
> - AcpiTable table = { .sig = "APIC", .rev = 6, .oem_id = s->oem_id,
> + AcpiTable table = { .sig = "APIC", .rev = 7, .oem_id = s->oem_id,
> .oem_table_id = s->oem_table_id };
Add comments citing the spec version and chapter.
> acpi_table_begin(&table, table_data);
> --
> 2.43.0
