On Tue, Jul 15, 2025 at 9:15 AM Michael S. Tsirkin <m...@redhat.com> wrote:
>
> We are going to be adding more parameters, and this makes
> rust unhappy:
> Functions with lots of parameters are considered bad style and reduce
> readability (“what does the 5th parameter mean?”). Consider grouping
> some parameters into a new type.
>
> Specifically:
>
> error: this function has too many arguments (8/7)
> -->
> /builds/mstredhat/qemu/build/rust/qemu-api/rust-qemu-api-tests.p/structured/bindings.inc.rs:3840:5
> |
> 3840 | / pub fn new_bitfield_1(
> 3841 | | secure: std::os::raw::c_uint,
> 3842 | | space: std::os::raw::c_uint,
> 3843 | | user: std::os::raw::c_uint,
> ... |
> 3848 | | address_type: std::os::raw::c_uint,
> 3849 | | ) -> __BindgenBitfieldUnit<[u8; 4usize]> {
> | |____________________________________________^
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
> = note: `-D clippy::too-many-arguments` implied by `-D warnings`
> = help: to override `-D warnings` add
> `#[allow(clippy::too_many_arguments)]`
>
> Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> rust/qemu-api/src/bindings.rs | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/rust/qemu-api/src/bindings.rs b/rust/qemu-api/src/bindings.rs
> index 057de4b646..c4f1f755ce 100644
> --- a/rust/qemu-api/src/bindings.rs
> +++ b/rust/qemu-api/src/bindings.rs
> @@ -13,7 +13,8 @@
> clippy::missing_const_for_fn,
> clippy::ptr_offset_with_cast,
> clippy::useless_transmute,
> - clippy::missing_safety_doc
> + clippy::missing_safety_doc,
> + clippy::too_many_arguments
> )]
>
> //! `bindgen`-generated declarations.
> --
> MST
>
Reviewed-by: Manos Pitsidianakis <manos.pitsidiana...@linaro.org>
