On Wed, 2 Jul 2025 at 13:22, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> Gvec only operates on size 8 and multiples of 16.
> Predicates may be any multiple of 2.
> Round up the size using the appropriate function.
>
> Cc: qemu-sta...@nongnu.org
> Fixes: 598ab0b24c0 ("target/arm: Implement PSEL")
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
> target/arm/tcg/translate-sve.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
> index a0de5b488d..8403034a0e 100644
> --- a/target/arm/tcg/translate-sve.c
> +++ b/target/arm/tcg/translate-sve.c
> @@ -7291,6 +7291,7 @@ static bool trans_PSEL(DisasContext *s, arg_psel *a)
> tcg_gen_neg_i64(tmp, tmp);
>
> /* Apply to either copy the source, or write zeros. */
> + pl = size_for_gvec(pl);
> tcg_gen_gvec_ands(MO_64, pred_full_reg_offset(s, a->pd),
> pred_full_reg_offset(s, a->pn), tmp, pl, pl);
> return true;
> --
> 2.43.0
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
