On Tue, May 15, 2012 at 11:21:13AM +0800, dunrong huang wrote: > Thanks for your reply. > > As you say, for an input visitor we dont need to initialize the pointer. > "visit_type_str" in set_mac function and set_pci_devfn function is a input > visitor, it points to > "qmp_input_type_str", if qmp_input_type_str failed, it will alloc a Error > struct and return. > > So, i think it doesnt matter whether initializing it or not in this > situation. > But the str must be freed to avoid memory leak
Want to send a fixed "[PATCH 1.1 v2]" that can be merged for QEMU 1.1? Please go directly through Anthony Liguori or another qemu.git committer instead of qemu-trivial for QEMU 1.1 fixes. Stefan
